spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14244][SQL] Don't use SizeBasedWindowFu...
Date Thu, 31 Mar 2016 20:36:32 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12040#discussion_r58123254
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
    @@ -920,7 +931,7 @@ private[execution] object AggregateProcessor {
         // Create the projections.
         val initialProjection = newMutableProjection(
           initialValues,
    -      Seq(SizeBasedWindowFunction.n))()
    +      Seq(partitionSize))()
    --- End diff --
    
    An initial value is allmost allways a constant. So in that case you don't need an input
variable. `partitionSize` is a bit special because we know the value before the aggregates
get initialized but not early enough to efficiently employ somekind of folding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message