spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...
Date Thu, 31 Mar 2016 01:34:03 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12009#discussion_r57990860
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql: String) extends RunnableCommand
{
     
     }
     
    +/**
    + * A command for users to create a new database.
    + *
    + * It will issue an error message when the database with the same name already exists,
    + * unless 'ifNotExists' is true.
    + * The syntax of using this command in SQL is:
    + * {{{
    + *    CREATE DATABASE|SCHEMA [IF NOT EXISTS] database_name
    + * }}}
    + */
     case class CreateDatabase(
         databaseName: String,
         ifNotExists: Boolean,
         path: Option[String],
         comment: Option[String],
    -    props: Map[String, String])(sql: String)
    -  extends NativeDDLCommand(sql) with Logging
    +    props: Map[String, String])
    +  extends RunnableCommand {
    +
    +  override def run(sqlContext: SQLContext): Seq[Row] = {
    +    val catalog = sqlContext.sessionState.catalog
    +    catalog.createDatabase(
    +      CatalogDatabase(
    +        databaseName,
    +        comment.getOrElse(""),
    +        path.getOrElse(catalog.getDefaultDBPath(databaseName)),
    +        props),
    +      ifNotExists)
    +    Seq.empty[Row]
    +  }
    --- End diff --
    
    True. Only did it in the default DB path. I forgot to do it in the regular case : ( Let
me submit a follow-up PR for it. Thanks for catching it! 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message