spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sameeragarwal <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14278][SQL] Initialize columnar batch w...
Date Wed, 30 Mar 2016 19:09:09 GMT
Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12070#discussion_r57945560
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
    @@ -191,7 +191,7 @@ public void initBatch(MemoryMode memMode, StructType partitionColumns,
           }
         }
     
    -    columnarBatch = ColumnarBatch.allocate(batchSchema);
    +    columnarBatch = ColumnarBatch.allocate(batchSchema, memMode);
    --- End diff --
    
    I considered it, but the single-argument `allocate` is currently also used in `DataSourceStrategy`.
Can we change it there? cc @nongli 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message