spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <>
Subject [GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...
Date Wed, 30 Mar 2016 16:28:11 GMT
Github user gatorsmile commented on a diff in the pull request:
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
    @@ -31,9 +31,11 @@ class DDLSuite extends QueryTest with SharedSQLContext {
       private def withDatabase(dbNames: String*)(f: => Unit): Unit = {
         try f finally {
    +      val currentDb = sqlContext.sessionState.catalog.getCurrentDatabase
           dbNames.foreach { name =>
             sqlContext.sql(s"DROP DATABASE IF EXISTS $name CASCADE")
    +      sqlContext.sessionState.catalog.setCurrentDatabase(currentDb)
    --- End diff --
    IMO, we do not need nested cases now. If multiple databases are used, we can do something
    withDatabase("db1", "db2")

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message