spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...
Date Tue, 29 Mar 2016 17:02:35 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12002#discussion_r57759763
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
    @@ -385,9 +385,9 @@ abstract class OutputWriter {
      *
      * @param location A [[FileCatalog]] that can enumerate the locations of all the files
that comprise
      *                 this relation.
    - * @param partitionSchema The schmea of the columns (if any) that are used to partition
the relation
    + * @param partitionSchema The schema of the columns (if any) that are used to partition
the relation
      * @param dataSchema The schema of any remaining columns.  Note that if any partition
columns are
    - *                   present in the actual data files as well, they are removed.
    + *                   present in the actual data files as well, they are preserved.
    --- End diff --
    
    The `dataSchema` you mentioned above is argument of `buildReader()`, which does get partitioned
columns stripped. But it's different from `FileFormat.dataSchema`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message