spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...
Date Tue, 29 Mar 2016 15:49:25 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12002#discussion_r57747564
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
    @@ -112,8 +105,9 @@ private[sql] object FileSourceStrategy extends Strategy with Logging
{
     
           val readFile = files.fileFormat.buildReader(
             sqlContext = files.sqlContext,
    +        physicalSchema = files.dataSchema,
    --- End diff --
    
    why do we call it `physicalSchema`? It's kind of a reconciled schema that may not equal
to the real physical schema.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message