spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread
Date Mon, 28 Mar 2016 17:39:47 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11971#discussion_r57602452
  
    --- Diff: core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala ---
    @@ -0,0 +1,106 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.util
    +
    +import javax.annotation.concurrent.GuardedBy
    +
    +/**
    + * A special Thread that provides "runUninterruptibly" to allow running codes without
being
    + * interrupted by `Thread.interrupt()`. If `Thread.interrupt()` is called during runUninterruptibly
    + * is running, it won't set the interrupted status. Instead, setting the interrupted
status will be
    + * deferred until it's returning from "runUninterruptibly".
    + *
    + * Note: this method should be called only in `this` thread.
    + */
    +private[spark] class UninterruptibleThread(name: String) extends Thread(name) {
    +
    +  /** A monitor to protect "uninterruptible" and "interrupted" */
    +  private val uninterruptibleLock = new Object
    +
    +  /**
    +   * Indicates if `this`  thread are in the uninterruptible status. If so, interrupting
    +   * "this" will be deferred until `this`  enters into the interruptible status.
    +   */
    +  @GuardedBy("uninterruptibleLock")
    +  private var uninterruptible = false
    +
    +  /**
    +   * Indicates if we should interrupt `this` when we are leaving the uninterruptible
zone.
    +   */
    +  @GuardedBy("uninterruptibleLock")
    +  private var shouldInterruptThread = false
    +
    +  /**
    +   * Run `f` uninterruptibly in `this` thread. The thread won't be interrupted before
returning
    +   * from `f`.
    +   *
    +   * Note: this method should be called only in `this` thread.
    +   */
    +  def runUninterruptibly[T](f: => T): T = {
    +    if (Thread.currentThread() != this) {
    +      throw new IllegalStateException(s"Call runUninterruptibly in a wrong thread. "
+
    +        s"Expected: $this but was ${Thread.currentThread()}")
    +    }
    +
    --- End diff --
    
    In this case, it should clear the interrupt status and set it back after calling `f`.
`StreamExecution` allows people to `interrupt` at any time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message