spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14170] [infra] Simplify the PR template...
Date Mon, 28 Mar 2016 17:24:23 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/11973#issuecomment-202495377
  
    @rxin do you mean you prefer the style where people replace portions of the template with
text?
    
    I can see why some would prefer that, but it makes a little harder to remove text. For
example, you can't remote the `## How was this patch tested?` part because people generally
write like this:
    
        ## How was this patch tested?
    
        unit tests
    
    So if you remove it, the message becomes a little nonsensical. You can remove the `(Please
blah blah` instructions, but those provide just a minor gain - and people generally remove
them anyway.
    
    Anyway, I'm ok with just leaving things as is, although personally I kinda dislike the
noise added to every commit message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message