spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <>
Subject [GitHub] spark pull request: [SPARK-14085] [SQL] Star Expansion for Hash
Date Thu, 24 Mar 2016 00:51:54 GMT
Github user cloud-fan commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
    @@ -414,6 +399,22 @@ class Analyzer(
    +     * Build a project list for Project/Aggregate and expand the star if possible
    +     */
    +    private def buildExpandedProjectList(
    +        exprs: Seq[NamedExpression],
    +        plan: LogicalPlan): Seq[NamedExpression] = {
    --- End diff --
    minor: name it `child` seems better, as the `expandStarExpression` also name the `LogicalPlan`
parameter `child`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message