spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajeshbalamohan <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-14091 [core] Consider improving performa...
Date Wed, 23 Mar 2016 12:10:32 GMT
Github user rajeshbalamohan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11911#discussion_r57148521
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1745,10 +1745,11 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
        * has overridden the call site using `setCallSite()`, this will return the user's
version.
        */
       private[spark] def getCallSite(): CallSite = {
    -    val callSite = Utils.getCallSite()
         CallSite(
    -      Option(getLocalProperty(CallSite.SHORT_FORM)).getOrElse(callSite.shortForm),
    -      Option(getLocalProperty(CallSite.LONG_FORM)).getOrElse(callSite.longForm)
    +      Option(getLocalProperty(CallSite.SHORT_FORM))
    --- End diff --
    
    Thanks @srowen . Incorporated the review comments in the latest commit. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message