spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-14092] [SQL] move shouldStop() to end o...
Date Wed, 23 Mar 2016 06:44:39 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11912#discussion_r57115978
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -255,11 +255,11 @@ private[sql] case class DataSourceScan(
           |       $numOutputRows.add(numRows);
           |     }
           |
    -      |     while (!shouldStop() && $idx < numRows) {
    +      |     while ($idx < numRows) {
           |       int $rowidx = $idx++;
           |       ${consume(ctx, columns1).trim}
    +      |       if (shouldStop()) return;
    --- End diff --
    
    Can we add some comment somewhere to explain why shouldStop needs to be here? It'd be
great to reference the JIRA ticket.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message