spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <>
Subject [GitHub] spark pull request: [SPARK-13919] [SQL] fix column pruning through...
Date Mon, 21 Mar 2016 20:47:27 GMT
Github user davies commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
    @@ -407,6 +407,16 @@ object ColumnPruning extends Rule[LogicalPlan] {
         } else {
    +  /**
    +   * The Project before Filter is not necessary but conflict with PushPredicatesThroughProject,
    +   * so remove it.
    +   */
    +  private def removeProjectBeforeFilter(plan: LogicalPlan): LogicalPlan = plan transform
    --- End diff --
    We usually use `transform` in everywhere, even we know that tranformDown is better, for
example, all those rules that push down a predicate.
    I think it's fine, or we should update all these places.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message