spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13805][SQL] Generate code that get a va...
Date Sat, 19 Mar 2016 04:32:20 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11636#discussion_r56743960
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -217,9 +222,16 @@ private[sql] case class DataSourceScan(
         // TODO: The abstractions between this class and SqlNewHadoopRDD makes it difficult
to know
         // here which path to use. Fix this.
     
    -    ctx.INPUT_ROW = row
    +    // These assignments avoids accesses to instance variables in a while-loop
    +    // Since they are loop invariant variables (LIVs), host them outside the while-loop
    +    val colLocalVars = output.zipWithIndex.map(x => ctx.freshName("col" + x._2))
    +    val columnLIVAssigns = (colLocalVars zip colVars).map { case (localName, name) =>
    --- End diff --
    
    Since we have `colVars`, do we still need `colLocalVars`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message