spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12182][ML] Distributed binning for tree...
Date Sat, 19 Mar 2016 03:24:43 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10231#discussion_r56743243
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
    @@ -956,7 +956,7 @@ private[ml] object RandomForest extends Logging {
             valueCounts.map(_._1)
           } else {
             // stride between splits
    -        val stride: Double = featureSamples.length.toDouble / (numSplits + 1)
    +        val stride: Double = featureSamples.size.toDouble / (numSplits + 1)
    --- End diff --
    
    Thanks for the suggestion! The latest commit should take care of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message