spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12555][SQL] Validate correct data is re...
Date Fri, 18 Mar 2016 01:45:57 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11623#discussion_r56604136
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
    @@ -206,4 +216,12 @@ class DatasetAggregatorSuite extends QueryTest with SharedSQLContext
{
           ds.groupByKey(_.b).agg(ComplexBufferAgg.toColumn),
           ("one", 1), ("two", 1))
       }
    +
    +  test("SPARK-12555 - data is not corrupted after input data is reordered") {
    --- End diff --
    
    I looked through the comment history of the JIRA, seems this bug is exposed by re-ordering
columns when covert to Dataset, e.g. `sql("select b, a ...").as[AggData]`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message