spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From avulanov <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11262][ML] Unit test for gradient, loss...
Date Thu, 17 Mar 2016 19:53:36 GMT
Github user avulanov commented on the pull request:

    https://github.com/apache/spark/pull/9229#issuecomment-198056498
  
    @mengxr Thank you for reviewing! I've addressed all comments, except
    
      - Return mutated parameter instead of `Unit`. I believe that it might be misleading
because one might expect getting a new object. `Unit` gives a hint that the state of parameters
might be mutated because no variable is returned.
      - Rename `weights` to `coefficients` to make it consistent with logistic regression
naming. Weights is a widely accepted term in artificial neural network domain. `coefficients`
might be confusing.
      - Could you elaborate on "4 space indentation"?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message