spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <>
Subject [GitHub] spark pull request: [SPARK-13805][SQL] Generate code that get a va...
Date Thu, 17 Mar 2016 17:05:09 GMT
Github user davies commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
    @@ -199,7 +210,8 @@ class CodegenContext {
           case StringType => s"$input.getUTF8String($ordinal)"
           case BinaryType => s"$input.getBinary($ordinal)"
           case CalendarIntervalType => s"$input.getInterval($ordinal)"
    -      case t: StructType => s"$input.getStruct($ordinal, ${t.size})"
    +      case t: StructType => if (!isColumnarType(input)) { s"$input.getStruct($ordinal,
${t.size})" }
    --- End diff --
    Right now, the parquet reader does not support nested types (Array, Map, Struct), it's
fine to not have this special case in this PR.  

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message