spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13853][SQL] QueryPlan sub-classes shoul...
Date Thu, 17 Mar 2016 09:48:23 GMT
Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/11673#issuecomment-197792870
  
    hi @marmbrus , yes your idea makes sense, we should use `Alias` to produce new attributes
if we can. Except leaf nodes, there are some special cases we still need to use `producedAttributes`:
`Generate`, `Expand`, `ScriptTransform` and aggregate related operators. In this PR, I made
`EvaluatePython` to use alias for new attribute, and clean up those special cases to use `producedAttributes`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message