spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-9926: Parallelize partition logic in Uni...
Date Wed, 16 Mar 2016 23:17:24 GMT
Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11242#discussion_r56432618
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/UnionRDD.scala ---
    @@ -62,7 +64,21 @@ class UnionRDD[T: ClassTag](
         var rdds: Seq[RDD[T]])
       extends RDD[T](sc, Nil) {  // Nil since we implement getDependencies
     
    +  // Evaluate partitions in parallel. Partitions of each rdd will be cached by the `partitions`
    +  // val in `RDD`.
    +  private lazy val evaluatePartitions: Unit = {
    +    val threshold = conf.getInt("spark.rdd.parallelListingThreshold", 10)
    +    if (threshold > 0 && rdds.length > threshold) {
    +      val parArray = rdds.toParArray
    +      parArray.tasksupport = new ForkJoinTaskSupport(new ForkJoinPool(threshold))
    +      parArray.foreach(_.partitions)
    +    } else {
    --- End diff --
    
    `false` and remove `rdds.foreach(_.partitions)` to make it evaluate in the original path.
Thus, you can check if we go through this path in unit test.
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message