spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...
Date Wed, 16 Mar 2016 20:17:05 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11663#discussion_r56406675
  
    --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
    @@ -105,64 +104,71 @@ def get$Name(self):
     if __name__ == "__main__":
         print(header)
         print("\n# DO NOT MODIFY THIS FILE! It was generated by _shared_params_code_gen.py.\n")
    -    print("from pyspark.ml.param import Param, Params\n\n")
    +    print("from pyspark.ml.param import *\n\n")
         shared = [
    -        ("maxIter", "max number of iterations (>= 0).", None, int),
    -        ("regParam", "regularization parameter (>= 0).", None, float),
    -        ("featuresCol", "features column name.", "'features'", str),
    -        ("labelCol", "label column name.", "'label'", str),
    -        ("predictionCol", "prediction column name.", "'prediction'", str),
    +        ("maxIter", "max number of iterations (>= 0).", None, "TypeConverters.convertToInt"),
    +        ("regParam", "regularization parameter (>= 0).", None, "TypeConverters.convertToFloat"),
    +        ("featuresCol", "features column name.", "'features'", None),
    +        ("labelCol", "label column name.", "'label'", None),
    +        ("predictionCol", "prediction column name.", "'prediction'", None),
             ("probabilityCol", "Column name for predicted class conditional probabilities.
" +
              "Note: Not all models output well-calibrated probability estimates! These probabilities
" +
    -         "should be treated as confidences, not precise probabilities.", "'probability'",
str),
    +         "should be treated as confidences, not precise probabilities.", "'probability'",
None),
             ("rawPredictionCol", "raw prediction (a.k.a. confidence) column name.", "'rawPrediction'",
    -         str),
    -        ("inputCol", "input column name.", None, str),
    -        ("inputCols", "input column names.", None, None),
    -        ("outputCol", "output column name.", "self.uid + '__output'", str),
    -        ("numFeatures", "number of features.", None, int),
    +         None),
    +        ("inputCol", "input column name.", None, None),
    +        ("inputCols", "input column names.", None, "TypeConverters.convertToList"),
    --- End diff --
    
    Handle list of str too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message