spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <>
Subject [GitHub] spark pull request: [SPARK-13934][SQL] Fixed table name parsing
Date Wed, 16 Mar 2016 13:16:43 GMT
Github user hvanhovell commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/CatalystQlSuite.scala
    @@ -171,6 +171,7 @@ class CatalystQlSuite extends PlanTest {
       test("table identifier") {
         assert(TableIdentifier("q") === parser.parseTableIdentifier("q"))
         assert(TableIdentifier("q", Some("d")) === parser.parseTableIdentifier("d.q"))
    +    assert(TableIdentifier("104e4d676bac4d9aa3856f00b5b9f51c") === parser.parseTableIdentifier("104e4d676bac4d9aa3856f00b5b9f51c"))
    --- End diff --
    You are not testing the AbstractSQLParser here but CatalystQl (which probably supports
such a table identifier).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message