spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sameeragarwal <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13811][SPARK-13836] [SQL] Removed IsNot...
Date Mon, 14 Mar 2016 18:08:56 GMT
Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11649#discussion_r56047794
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/ConstraintPropagationSuite.scala
---
    @@ -217,4 +217,19 @@ class ConstraintPropagationSuite extends SparkFunSuite {
             IsNotNull(resolveColumn(tr, "a")),
             IsNotNull(resolveColumn(tr, "b")))))
       }
    +
    +  test("IsNotNull constraints of compound expressions in filters") {
    --- End diff --
    
    nit: "no IsNotNull constraints are generated for compound expressions in filters" (here
and in the test below)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message