spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From WangTaoTheTonic <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13852][YARN]handle the InterruptedExcep...
Date Mon, 14 Mar 2016 09:30:38 GMT
Github user WangTaoTheTonic commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11692#discussion_r55973772
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -976,6 +976,11 @@ private[spark] class Client(
                 logError(s"Application $appId not found.")
                 return (YarnApplicationState.KILLED, FinalApplicationStatus.KILLED)
               case NonFatal(e) =>
    +            if (e.isInstanceOf[InterruptedException]
    --- End diff --
    
    we can only move InterruptedException to above but not exception cause by it.
    `just move InterruptedException`  or `leave these two here`, which option do you think
is better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message