spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...
Date Thu, 10 Mar 2016 19:40:35 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11152#discussion_r55737357
  
    --- Diff: docs/monitoring.md ---
    @@ -273,8 +309,8 @@ for a running application, at `http://localhost:4040/api/v1`.
         <td>Download the event logs for all attempts of the given application as a
zip file</td>
       </tr>
       <tr>
    -    <td><code>/applications/[app-id]/[attempt-id]/logs</code></td>
    -    <td>Download the event logs for the specified attempt of the given application
as a zip file</td>
    +    <td><code>/applications/[app-id]/logs</code></td>
    +    <td>Download the event logs for the application as a zip file</td>
    --- End diff --
    
    this change looks wrong -- there are two endpoints, one for all attempts for the applications,
and another for just one attempt.  The docs for the all-attempt endpoint is above this one.
 with this change, its just duplicated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message