spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13732] [SPARK-13797] [SPARK-13798] [SQL...
Date Thu, 10 Mar 2016 07:27:26 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11565#discussion_r55642323
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
    @@ -384,9 +374,25 @@ object ColumnPruning extends Rule[LogicalPlan] {
         // Eliminate no-op Projects
         case p @ Project(projectList, child) if sameOutput(child.output, p.output) =>
child
     
    +    // Eliminate no-op Window
    +    case w: Window if sameOutput(w.child.output, w.output) => w.child
    +
    +    // Convert Aggregate to Project if no aggregate function exists
    +    case a: Aggregate if !containsAggregates(a.expressions) =>
    +      Project(a.aggregateExpressions, a.child)
    --- End diff --
    
    But `Aggregate` will do grouping, even there is no aggregate expressions, I think this
is not right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message