spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13674][SQL] Add wholestage codegen supp...
Date Wed, 09 Mar 2016 06:04:55 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11517#discussion_r55475367
  
    --- Diff: core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
    @@ -41,6 +41,12 @@ trait RandomSampler[T, U] extends Pseudorandom with Cloneable with
Serializable
       /** take a random sample */
       def sample(items: Iterator[T]): Iterator[U]
     
    +  /**
    +   * Whether to sample the next item or not.
    +   * Return how many times the next item will be sampled. Return 0 if it is not sampled.
    +   */
    +  def sample(): Int
    +
    --- End diff --
    
    These changes on `RandomSampler` is submitted in #11578.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message