spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13659] Refactor BlockStore put*() APIs ...
Date Tue, 08 Mar 2016 05:47:43 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11502#discussion_r55319064
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
    @@ -54,15 +54,12 @@ private[spark] class DiskStore(blockManager: BlockManager, diskManager:
DiskBloc
         val finishTime = System.currentTimeMillis
         logDebug("Block %s stored as %s file on disk in %d ms".format(
           file.getName, Utils.bytesToString(bytes.limit), finishTime - startTime))
    -    PutResult(bytes.limit(), Right(bytes.duplicate()))
       }
     
       override def putIterator(
           blockId: BlockId,
           values: Iterator[Any],
    -      level: StorageLevel,
    -      returnValues: Boolean): PutResult = {
    -
    +      level: StorageLevel): Right[Iterator[Any], Long] = {
    --- End diff --
    
    This return type is really wonky. We can fix this later though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message