spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markhamstra <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13566] Avoid deadlock between BlockMana...
Date Mon, 07 Mar 2016 21:13:40 GMT
Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11546#discussion_r55273032
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -227,6 +228,17 @@ private[spark] class Executor(
                   logError(errMsg)
                 }
               }
    +
    +          if (releasedLocks.nonEmpty) {
    +            val errMsg =
    +              s"${releasedLocks.size} block locks were not released by TID = $taskId:\n"
+
    --- End diff --
    
    ...which would tend to argue that this should be named unreleasedLocks, not releasedLocks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message