spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13616][SQL] Let SQLBuilder convert logi...
Date Sat, 05 Mar 2016 09:06:59 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11466#discussion_r55118355
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
    @@ -78,6 +78,27 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext: SQLContext)
extends Loggi
         }
       }
     
    +  private def toSQL(node: LogicalPlan, topNode: Boolean): String = {
    --- End diff --
    
    If the algorithm can convert an analyzed logical plan back to SQL. I can't see why we
can't let it convert its child plan back to SQL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message