spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13659] Refactor BlockStore put*() APIs ...
Date Fri, 04 Mar 2016 00:30:22 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11502#discussion_r54972981
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -734,9 +740,9 @@ private[spark] class BlockManager(
        * @param keepReadLock if true, this method will hold the read lock when it returns
(even if the
        *                     block already exists). If false, this method will hold no locks
when it
        *                     returns.
    -   * @return `Some(PutResult)` if the block did not exist and could not be successfully
cached,
    -   *         or None if the block already existed or was successfully stored (fully consuming
    -   *         the input data / input iterator).
    +   * @return `Some(Option[Iterator[Any])` if the block did not exist and could not be
successfully
    --- End diff --
    
    This will be much easier to clean up if we split the monolithic `doPut()` into a `doPutBytes()`
and `doPutIterator()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message