spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12720] [SQL] SQL Generation Support for...
Date Thu, 03 Mar 2016 04:37:40 GMT
Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/11283#issuecomment-191578269
  
    overall LGTM, but we can leverage more information to make the code simpler. For example,
`Aggregate.groupingExpressions` are guaranteed to be `Attribute`s, each projection list in
`expand.projections` are compose by `original output` + `group by attributes` + `gid`, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message