spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13603] [SQL] support SQL generation for...
Date Thu, 03 Mar 2016 04:26:24 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11453#discussion_r54834937
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala
---
    @@ -268,4 +268,9 @@ class ExpressionToSQLSuite extends SQLBuilderTest with SQLTestUtils
{
         checkSqlGeneration("SELECT input_file_name()")
         checkSqlGeneration("SELECT monotonically_increasing_id()")
       }
    +
    +  test("subquery") {
    +    checkSqlGeneration("SELECT 1 + (SELECT 2)")
    +    checkSqlGeneration("SELECT 1 + (SELECT 2 + (SELECT 3 as a))")
    --- End diff --
    
    Not necessary, different test suite for different purpose, we should not repeat every
test cases everywhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message