spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13466][SQL] Remove redundant projects i...
Date Thu, 03 Mar 2016 03:43:42 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11341#discussion_r54832817
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala
---
    @@ -249,5 +249,26 @@ class ColumnPruningSuite extends PlanTest {
         comparePlans(Optimize.execute(query), expected)
       }
     
    +  test("Remove redundant Project introduced by column pruning rule") {
    +    val input = LocalRelation('key.int, 'value.string)
    +
    +    val query =
    +      Project(Seq($"x.key", $"y.key"),
    --- End diff --
    
    Hmm, maybe I shouldn't say that removing redundant Project introduced by column pruning.
It is not accurate. The Project is becoming redundant after column pruning optimizes the plan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message