Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAC4A18A5A for ; Sat, 27 Feb 2016 00:28:48 +0000 (UTC) Received: (qmail 15043 invoked by uid 500); 27 Feb 2016 00:28:48 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 15017 invoked by uid 500); 27 Feb 2016 00:28:48 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 15006 invoked by uid 99); 27 Feb 2016 00:28:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Feb 2016 00:28:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 64561E0211; Sat, 27 Feb 2016 00:28:48 +0000 (UTC) From: BryanCutler To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-12633][PYSPARK] [DOC] PySpark regressio... Content-Type: text/plain Message-Id: <20160227002848.64561E0211@git1-us-west.apache.org> Date: Sat, 27 Feb 2016 00:28:48 +0000 (UTC) Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/11404#discussion_r54321225 --- Diff: python/pyspark/mllib/regression.py --- @@ -368,56 +365,53 @@ def load(cls, sc, path): class LassoWithSGD(object): """ - Train a regression model with L1-regularization using Stochastic Gradient Descent. - This solves the L1-regularized least squares regression formulation - - f(weights) = 1/2n ||A weights-y||^2 + regParam ||weights||_1 - - Here the data matrix has n rows, and the input RDD holds the set of rows of A, each with - its corresponding right hand side label y. - See also the documentation for the precise formulation. - --- End diff -- Same here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org