Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: JoshRosen <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-11309-spark@git.apache.org>
In-Reply-To: <git-pr-11309-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-13298][Core][UI]Escape "label" to
 avoid...
Content-Type: text/plain
Message-Id: <20160222221509.4A286E03CE@git1-us-west.apache.org>
Date: Mon, 22 Feb 2016 22:15:09 +0000 (UTC)

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11309#discussion_r53702593
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala ---
    @@ -20,10 +20,11 @@ package org.apache.spark.ui.scope
     import scala.collection.mutable
     import scala.collection.mutable.{ListBuffer, StringBuilder}
     
    +import org.apache.commons.lang.StringEscapeUtils
    --- End diff --
    
    Hey, we should add a style-checker rule to ban the `commons.lang` import.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org