Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-10757-spark@git.apache.org>
In-Reply-To: <git-pr-10757-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-12799] Simplify various string
 output f...
Content-Type: text/plain
Message-Id: <20160216123823.8DC99E0534@git1-us-west.apache.org>
Date: Tue, 16 Feb 2016 12:38:23 +0000 (UTC)

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10757#discussion_r53004680
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonUDF.scala ---
    @@ -36,9 +36,12 @@ case class PythonUDF(
         broadcastVars: java.util.List[Broadcast[PythonBroadcast]],
         accumulator: Accumulator[java.util.List[Array[Byte]]],
         dataType: DataType,
    -    children: Seq[Expression]) extends Expression with Unevaluable with Logging {
    +    children: Seq[Expression])
    +  extends Expression with Unevaluable with NonSQLExpression with Logging {
     
    -  override def toString: String = s"PythonUDF#$name(${children.mkString(",")})"
    +  override def toString: String = s"PythonUDF#$name(${children.mkString(", ")})"
     
       override def nullable: Boolean = true
    +
    +  override def sql: String = s"$name(${children.mkString(", ")})"
    --- End diff --
    
    It extends `NonSQLExpression`, no need to implement it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org