Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: sethah <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-11099-spark@git.apache.org>
In-Reply-To: <git-pr-11099-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Extend
 Pyspark para...
Content-Type: text/plain
Message-Id: <20160208211250.7BED0E00B2@git1-us-west.apache.org>
Date: Mon,  8 Feb 2016 21:12:50 +0000 (UTC)

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11099#discussion_r52225995
  
    --- Diff: python/pyspark/ml/param/__init__.py ---
    @@ -49,11 +53,21 @@ def _copy_new_parent(self, parent):
             else:
                 raise ValueError("Cannot copy from non-dummy parent %s." % parent)
     
    +    def _validate(self, value):
    +        if not self.isValid(value):
    +            raise ValueError("{parent} parameter {name} given invalid value {value}"
    +                             .format(parent=self.parent, name=self.name, value=str(value)))
    +
    +    def _convertAndValidate(self, value):
    --- End diff --
    
    I added a docstring to the base classes. I am not sure if the derived classes need docstrings as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org