spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12941][SQL][MASTER] Spark-SQL JDBC Orac...
Date Fri, 26 Feb 2016 06:49:07 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11306#discussion_r54210205
  
    --- Diff: docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.jdbc
    +
    +import java.math.BigDecimal
    +import java.sql.{Connection, Date, Timestamp}
    +import java.util.Properties
    +
    +import org.apache.spark.sql.test.SharedSQLContext
    +import org.apache.spark.sql.types._
    +import org.apache.spark.tags.DockerTest
    +
    +/**
    + * This patch was tested using the Oracle docker. Created this integration suite for
the same.
    + * The ojdbc6-11.2.0.2.0.jar was to be downloaded from the maven repository. Since there
was
    + * no jdbc jar available in the maven repository, the jar was downloaded from oracle
site
    + * manually and installed in the local; thus tested. So, for SparkQA test case run, the
    + * ojdbc jar might be manually placed in the local maven repository(com/oracle/ojdbc6/11.2.0.2.0)
    + * while Spark QA test run.
    + *
    + * The following would be the steps to test this
    + * 1. Pull oracle 11g image - docker pull wnameless/oracle-xe-11g
    + * 2. Start docker - sudo service docker start
    + * 3. Download oracle 11g driver jar and put it in maven local repo:
    + *    (com/oracle/ojdbc6/11.2.0.2.0/ojdbc6-11.2.0.2.0.jar)
    + * 4. The timeout and interval parameter to be increased from 60,1 to a high value for
oracle test
    + *    in DockerJDBCIntegrationSuite.scala (Locally tested with 200,200 and executed successfully).
    + * 5. Run spark test - ./build/sbt "test-only org.apache.spark.sql.jdbc.OracleIntegrationSuite"
    + *
    + * All tests in this suite are ignored because of the dependency with the oracle jar
from maven
    + * repository.
    + */
    +@DockerTest
    +class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLContext
{
    --- End diff --
    
    oh nvm. Before will not be triggered since no test will run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message