spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zjffdu <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12994][CORE] It is not necessary to cre...
Date Tue, 23 Feb 2016 14:13:48 GMT
Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10914#discussion_r53784065
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2206,6 +2206,11 @@ private[spark] object Utils extends Logging {
         isInDirectory(parent, child.getParentFile)
       }
     
    +  def isLocal(conf: SparkConf): Boolean = {
    +    val master: String = conf.get("spark.master", "")
    --- End diff --
    
    Didn't change it because I think the current way is more readable. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message