spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13080] [SQL] Implement new Catalog API ...
Date Mon, 22 Feb 2016 18:49:40 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11293#discussion_r53671961
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveCatalog.scala ---
    @@ -0,0 +1,293 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.hive
    +
    +import scala.util.control.NonFatal
    +
    +import org.apache.hadoop.hive.ql.metadata.HiveException
    +import org.apache.thrift.TException
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.sql.AnalysisException
    +import org.apache.spark.sql.catalyst.analysis.NoSuchItemException
    +import org.apache.spark.sql.catalyst.catalog._
    +import org.apache.spark.sql.hive.client.HiveClient
    +
    +
    +/**
    + * A persistent implementation of the system catalog using Hive.
    + * All public methods must be synchronized for thread-safety.
    + */
    +private[spark] class HiveCatalog(client: HiveClient) extends Catalog with Logging {
    +  import Catalog._
    +
    +  // Exceptions thrown by the hive client that we would like to wrap
    +  private val clientExceptions = Set(
    +    classOf[HiveException].getCanonicalName,
    +    classOf[TException].getCanonicalName)
    +
    +  /**
    +   * Whether this is an exception thrown by the hive client that should be wrapped.
    +   *
    +   * Due to classloader isolation issues, pattern matching won't work here so we need
    +   * to compare the canonical names of the exceptions, which we assume to be stable.
    +   */
    +  private def isClientException(e: Throwable): Boolean = {
    +    var temp: Class[_] = e.getClass
    +    var found = false
    +    while (temp != null && !found) {
    +      found = clientExceptions.contains(temp.getCanonicalName)
    +      temp = temp.getSuperclass
    +    }
    +    found
    +  }
    +
    +  /**
    +   * Run some code involving `client` in a [[synchronized]] block and wrap certain
    +   * exceptions thrown in the process in [[AnalysisException]].
    +   */
    +  private def withClient[T](body: => T): T = synchronized {
    --- End diff --
    
    shouldn't all methods of the catalog be synchronized?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message