spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13428] [SQL] Pushing Down Aggregate Exp...
Date Mon, 22 Feb 2016 04:47:32 GMT
Github user gatorsmile commented on the pull request:

    https://github.com/apache/spark/pull/11298#issuecomment-187009069
  
    cc @davies @cloud-fan . This PR is like an incremental patch with few lines of code changes.
I am not sure if the whole rewrite is worthy for resolving the above two issues only when
there exist the other operators between `Sort` and `Aggregate`? After all, users can manually
correct their query if they hit a resolution issue when missing attributes in Sort happen.
We already cover most of cases. : ) 
    
    Let me know if you want a whole rewrite or just an incremental fix. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message