spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...
Date Fri, 19 Feb 2016 18:18:58 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11229#discussion_r53496574
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1595,10 +1594,8 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
             key = uri.getScheme match {
               // A JAR file which exists only on the driver node
               case null | "file" =>
    -            // yarn-standalone is deprecated, but still supported
    -            if (SparkHadoopUtil.get.isYarnMode() &&
    -                (master == "yarn-standalone" || master == "yarn-cluster")) {
    -              // In order for this to work in yarn-cluster mode the user must specify
the
    +            if (SparkHadoopUtil.get.isYarnMode() && (master == "yarn" &&
deployMode == "cluster")) {
    --- End diff --
    
    not your code, but this is kind of weird. At this point of master is `yarn` we should
be pretty sure `isYarnMode` is true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message