spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13248][STREAMING] Remove deprecated Str...
Date Wed, 17 Feb 2016 18:34:16 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11139#discussion_r53208878
  
    --- Diff: examples/src/main/java/org/apache/spark/examples/streaming/JavaRecoverableNetworkWordCount.java
---
    @@ -204,13 +202,17 @@ public static void main(String[] args) {
         final int port = Integer.parseInt(args[1]);
         final String checkpointDirectory = args[2];
         final String outputPath = args[3];
    -    JavaStreamingContextFactory factory = new JavaStreamingContextFactory() {
    +
    +    // Function to create JavaStreamingContext without any output operations
    +    // (used to detect the new context)
    +    Function0<JavaStreamingContext> createContextFunc = new Function0<JavaStreamingContext>()
{
    --- End diff --
    
    `new Function0<>` is valid Java. What do you mean? it's just simpler.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message