spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13249][SQL] Add Filter checking nullabi...
Date Wed, 17 Feb 2016 10:08:09 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11235#discussion_r53143261
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
    @@ -23,7 +23,7 @@ import org.apache.spark.sql.catalyst.analysis.{CleanupAliases, EliminateSubQueri
     import org.apache.spark.sql.catalyst.expressions._
     import org.apache.spark.sql.catalyst.expressions.Literal.{FalseLiteral, TrueLiteral}
     import org.apache.spark.sql.catalyst.expressions.aggregate._
    -import org.apache.spark.sql.catalyst.planning.{ExtractFiltersAndInnerJoins, Unions}
    +import org.apache.spark.sql.catalyst.planning._
    --- End diff --
    
    Nit: Is it better, `import org.apache.spark.sql.catalyst.planning.{ExtractEquiJoinKeys,
ExtractFiltersAndInnerJoins, Unions}`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message