spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yinxusen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13013][Docs] Replace example code in ml...
Date Tue, 16 Feb 2016 17:52:40 GMT
Github user yinxusen commented on the pull request:

    https://github.com/apache/spark/pull/11116#issuecomment-184798949
  
    Maybe not. Most of the style issues are checked by scalastyle, which also
    covers part of Java style. But there are also some corners not covered. The
    best way to know them is learning from other codes.
    
    2016年2月16日星期二,Xin Ren <notifications@github.com> 写道:
    
    > Hi @yinxusen <https://github.com/yinxusen> , is there a command to check
    > Java style, like checking scala by "examples/scalastyle"?
    >
    > I removed setMaster for all examples now, thanks a lot.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/11116#issuecomment-184658272>.
    >
    
    
    -- 
    Cheers
    -----------------------------------
    Xusen Yin    (尹绪森)
    LinkedIn: https://cn.linkedin.com/in/xusenyin



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message