spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <>
Subject [GitHub] spark pull request: [SPARK-12799] Simplify various string output f...
Date Tue, 16 Feb 2016 12:38:23 GMT
Github user cloud-fan commented on a diff in the pull request:
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonUDF.scala
    @@ -36,9 +36,12 @@ case class PythonUDF(
         broadcastVars: java.util.List[Broadcast[PythonBroadcast]],
         accumulator: Accumulator[java.util.List[Array[Byte]]],
         dataType: DataType,
    -    children: Seq[Expression]) extends Expression with Unevaluable with Logging {
    +    children: Seq[Expression])
    +  extends Expression with Unevaluable with NonSQLExpression with Logging {
    -  override def toString: String = s"PythonUDF#$name(${children.mkString(",")})"
    +  override def toString: String = s"PythonUDF#$name(${children.mkString(", ")})"
       override def nullable: Boolean = true
    +  override def sql: String = s"$name(${children.mkString(", ")})"
    --- End diff --
    It extends `NonSQLExpression`, no need to implement it?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message