spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...
Date Tue, 09 Feb 2016 17:52:14 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10838#discussion_r52345827
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
    @@ -143,9 +148,11 @@ final class ShuffleBlockFetcherIterator(
         logDebug("Sending request for %d blocks (%s) from %s".format(
           req.blocks.size, Utils.bytesToString(req.size), req.address.hostPort))
         bytesInFlight += req.size
    +    reqsInFlight += 1
     
         // so we can look up the size of each blockID
         val sizeMap = req.blocks.map { case (blockId, size) => (blockId.toString, size)
}.toMap
    +    val remainingBlocks = new ArrayBuffer[String]() ++ sizeMap.keys
    --- End diff --
    
    nit: use HashSet instead of `ArrayBuffer`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message