spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...
Date Tue, 09 Feb 2016 08:54:35 GMT
Github user dbtsai commented on the pull request:

    https://github.com/apache/spark/pull/11119#issuecomment-181766454
  
    Agree, for code-gen, if we want to do it in this way, we would rather put them in a separate
place. But will be nice to extend the code-gen framework so it can use one codebase to handle
generic type. 
    
    +@jkbradley @mengxr  BTW, we still need to run the separate `sbt` code to do code-gen,
and why don't we do it in the compile time using quasiquote? This will not hurt the performance
since it's compile time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message