spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-13225] [SQL] Support Intersect All/Dist...
Date Sun, 07 Feb 2016 09:03:36 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11106#discussion_r52114742
  
    --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlParser.g
---
    @@ -2222,7 +2223,9 @@ setOperator
         : KW_UNION KW_ALL -> ^(TOK_UNIONALL)
         | KW_UNION KW_DISTINCT? -> ^(TOK_UNIONDISTINCT)
         | KW_EXCEPT -> ^(TOK_EXCEPT)
    -    | KW_INTERSECT -> ^(TOK_INTERSECT)
    +    | KW_INTERSECT (all=KW_ALL | distinct=KW_DISTINCT)?
    +    -> {$all == null}? ^(TOK_INTERSECTDISTINCT)
    +    ->                 ^(TOK_INTERSECTALL)
    --- End diff --
    
    So distinct is optional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message