spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12476][SQL] Implement JdbcRelation#unha...
Date Sun, 07 Feb 2016 01:08:48 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10427#discussion_r52110498
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
    @@ -90,6 +90,11 @@ private[sql] case class JDBCRelation(
     
       override val schema: StructType = JDBCRDD.resolveTable(url, table, properties)
     
    +  // Check if JDBCRDD.compileFilter can accept input filters
    +  override def unhandledFilters(filters: Array[Filter]): Array[Filter] = {
    +    filters.filter(JDBCRDD.compileFilter(_).isEmpty)
    --- End diff --
    
    Thank you for the update!
    
    When we were using ` == null` (I guess all filters were marked as unhandled, right?),
all tests still passed. So, I am wondering if existing tests are sufficient?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message